This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: patch for binutils bfd/dwarf2.c


Hi Nathan,

> While merging into my code the latest cvs changes for bfd/dwarf2.c, I
> noticed the following (re: the patch below).
> 
> At line 1136:
> 
>     arange_add (unit, low_pc, high_pc);       <-----
>     if (low_pc == 0 || address < low_pc)
>       low_pc = address;
>     if (address > high_pc)
>       high_pc = address;
>     arange_add (unit, low_pc, address);       <-----
> 
> 
> Here, the range is added twice, and with possibly overlapping ranges.  Since
> this was different than both the original code and my patch, and since it
> looked like a mistake, I wanted to make sure you verified it.

Oops - typo in my part.  I have checked in a fix.

Cheers
        Nick


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]