This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH/RFA] SH TLS support (Take 3)


Hans-Peter Nilsson <hp@bitrange.com> wrote:
> On Thu, 10 Oct 2002, kaz Kojima wrote:
>> I've revised SH 32-bit TLS patch. There is no new regression for
>> sh-unknown-linux-gnu, sh4-unknown-netbsdelf and sh64-unknown-elf.
> 
> Thanks.  The patch is approved with the nits below fixed; you
> don't have to re-send the patch.

Thanks a lot.

>> @@ -33,4 +33,11 @@ foreach shtest $rd_test_list {
>>      # We need to strip the ".d", but can leave the dirname.
>>      verbose [file rootname $shtest]
>>      run_dump_test [file rootname $shtest]
>> +    if [string match $srcdir/$subdir/*-dso.d $shtest] {
>> +       set cmd "cp tmpdir/dump tmpdir/[file rootname [file tail $shtest]].so"
>> +       send_log "$cmd\n"
>> +       set cmdret [catch "exec $cmd" comp_output]
>> +       send_log "$comp_output\n"
>> +       # FIXME: What if it fails?  Need we do something?
>> +    }
>>  }
> 
> I see you went for a simpler scheme than in cris.exp; you
> require that the DSO-name sorts before the tests that depend on
> it rather than split out the DSO-creating tests and do them in a
> separate stage before the others.  I'm not against that, but a
> comment about the sort-order requirement would be in order, I
> think.

How about this?

    if [string match $srcdir/$subdir/*-dso.d $shtest] {
	# Copy the output of the DSO-creating test to .so file.
	# Notice that a DSO-creating test must precede the tests
	# which need that DSO in sort-order by name.
	set ...

>> --- ORIG/src/gas/testsuite/gas/sh/tlsd.d	Thu Jan  1 09:00:00 1970
>> +++ LOCAL/src/gas/testsuite/gas/sh/tlsd.d	Wed Oct  9 08:00:17 2002
>> @@ -0,0 +1,54 @@
>> +#objdump: -dr
>> +#name: sh dynamic tls
> 
> I think you need to say "#as: -little" here and in the other gas
> TLS tests, so big-endian targets don't fail the test.

TLS tests in gas/sh assume -big because basic.exp adds -big to
ASFLAGS for sh*-*-linux-gnu and the default endian of the other
targets are big-endian. But the explicit specification seems
better. I'd like to add "#as: -big" to these tests. OK?

Regards,
	kaz


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]