This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: QNX binutils targets
- From: "Graeme Peterson" <gp at qnx dot com>
- To: gp at qnx dot com (Graeme Peterson)
- Cc: amodra at bigpond dot net dot au (Alan Modra), binutils at sources dot redhat dot com
- Date: Fri, 18 Oct 2002 16:40:19 -0400 (EDT)
- Subject: Re: QNX binutils targets
I also noticed that not all of the qnx bfd's are in targets.c:
$ grep qnx targets.c
targets.c:extern const bfd_target bfd_elf32_bigarmqnx_vec;
targets.c:extern const bfd_target bfd_elf32_i386qnx_vec;
targets.c:extern const bfd_target bfd_elf32_littlearmqnx_vec;
targets.c:extern const bfd_target bfd_elf32_powerpcleqnx_vec;
targets.c:extern const bfd_target bfd_elf32_powerpcqnx_vec;
targets.c:extern const bfd_target bfd_elf32_shlqnx_vec;
targets.c:extern const bfd_target bfd_elf32_shqnx_vec;
targets.c: &bfd_elf32_i386qnx_vec,
targets.c: &bfd_elf32_powerpcleqnx_vec,
targets.c: &bfd_elf32_powerpcqnx_vec,
Shouldn't there also be:
targets.c: &bfd_elf32_bigarmqnx_vec,
targets.c: &bfd_elf32_littlearmqnx_vec,
targets.c: &bfd_elf32_shlqnx_vec,
targets.c: &bfd_elf32_shqnx_vec,
Looks like an ommission somewhere along the line.
Thanks.
GP
>
> Hi, Alan.
>
> I was away and missed your mail.
>
> Thanks for fixing this, it is fine with me (he said too late anyway).
>
> :-)
>
> Cheers.
> GP
>
> >
> > The QNX targets were reusing bfd target names. Not good if you're
> > building a multiple-target bfd lib and would like to specify a
> > QNX target. So I've chosen some new names, in line with other targets
> > that have a wrinkle on a more generic target. If the names don't suit,
> > speak up!
> >
> > bfd/ChangeLog
> > * elf32-i386qnx.c (TARGET_LITTLE_NAME): Define.
> > * elf32-ppcqnx.c (TARGET_LITTLE_NAME, TARGET_BIG_NAME): Define.
> > * elf32-shqnx.c (TARGET_LITTLE_NAME, TARGET_BIG_NAME): Define.
> > * elfarmqnx-nabi.c (TARGET_LITTLE_NAME, TARGET_BIG_NAME): Define.
> >
> > Index: bfd/elf32-i386qnx.c
> > ===================================================================
> > RCS file: /cvs/src/src/bfd/elf32-i386qnx.c,v
> > retrieving revision 1.3
> > diff -u -p -r1.3 elf32-i386qnx.c
> > --- bfd/elf32-i386qnx.c 9 Aug 2002 15:38:22 -0000 1.3
> > +++ bfd/elf32-i386qnx.c 15 Oct 2002 07:23:52 -0000
> > @@ -24,7 +24,8 @@
> > #include "elf32-qnx.h"
> >
> > #undef TARGET_LITTLE_SYM
> > -#define TARGET_LITTLE_SYM bfd_elf32_i386qnx_vec
> > +#define TARGET_LITTLE_SYM bfd_elf32_i386qnx_vec
> > +#undef TARGET_LITTLE_NAME
> > +#define TARGET_LITTLE_NAME "elf32-i386-nto"
> >
> > #include "elf32-target.h"
> > -
> > Index: bfd/elf32-ppcqnx.c
> > ===================================================================
> > RCS file: /cvs/src/src/bfd/elf32-ppcqnx.c,v
> > retrieving revision 1.1
> > diff -u -p -r1.1 elf32-ppcqnx.c
> > --- bfd/elf32-ppcqnx.c 9 Aug 2002 15:39:19 -0000 1.1
> > +++ bfd/elf32-ppcqnx.c 15 Oct 2002 07:23:52 -0000
> > @@ -25,8 +25,11 @@
> >
> > #undef TARGET_LITTLE_SYM
> > #define TARGET_LITTLE_SYM bfd_elf32_powerpcleqnx_vec
> > +#undef TARGET_LITTLE_NAME
> > +#define TARGET_LITTLE_NAME "elf32-powerpcle-nto"
> > #undef TARGET_BIG_SYM
> > #define TARGET_BIG_SYM bfd_elf32_powerpcqnx_vec
> > +#undef TARGET_BIG_NAME
> > +#define TARGET_BIG_NAME "elf32-powerpc-nto"
> >
> > #include "elf32-target.h"
> > -
> > Index: bfd/elf32-shqnx.c
> > ===================================================================
> > RCS file: /cvs/src/src/bfd/elf32-shqnx.c,v
> > retrieving revision 1.1
> > diff -u -p -r1.1 elf32-shqnx.c
> > --- bfd/elf32-shqnx.c 22 Aug 2002 17:27:19 -0000 1.1
> > +++ bfd/elf32-shqnx.c 15 Oct 2002 07:23:52 -0000
> > @@ -24,8 +24,11 @@
> >
> > #undef TARGET_LITTLE_SYM
> > #define TARGET_LITTLE_SYM bfd_elf32_shlqnx_vec
> > +#undef TARGET_LITTLE_NAME
> > +#define TARGET_LITTLE_NAME "elf32-shl-nto"
> > #undef TARGET_BIG_SYM
> > #define TARGET_BIG_SYM bfd_elf32_shqnx_vec
> > +#undef TARGET_BIG_NAME
> > +#define TARGET_BIG_NAME "elf32-sh-nto"
> >
> > #include "elf32-target.h"
> > -
> > Index: bfd/elfarmqnx-nabi.c
> > ===================================================================
> > RCS file: /cvs/src/src/bfd/elfarmqnx-nabi.c,v
> > retrieving revision 1.2
> > diff -u -p -r1.2 elfarmqnx-nabi.c
> > --- bfd/elfarmqnx-nabi.c 9 Aug 2002 15:38:22 -0000 1.2
> > +++ bfd/elfarmqnx-nabi.c 15 Oct 2002 07:23:52 -0000
> > @@ -24,8 +24,12 @@
> >
> > #undef TARGET_LITTLE_SYM
> > #define TARGET_LITTLE_SYM bfd_elf32_littlearmqnx_vec
> > +#undef TARGET_LITTLE_NAME
> > +#define TARGET_LITTLE_NAME "elf32-littlearm-nto"
> > #undef TARGET_BIG_SYM
> > #define TARGET_BIG_SYM bfd_elf32_bigarmqnx_vec
> > +#undef TARGET_BIG_NAME
> > +#define TARGET_BIG_NAME "elf32-bigarm-nto"
> >
> > /* QNX Neutrino for ARM has a max pagesize of 0x1000. */
> > #undef ELF_MAXPAGESIZE
> >
> > --
> > Alan Modra
> > IBM OzLabs - Linux Technology Centre
> >
>
>