This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
[PATCH] Remove perror() from archive.c
- From: Elias Athanasopoulos <eathan at otenet dot gr>
- To: binutils at sources dot redhat dot com
- Date: Sun, 20 Oct 2002 16:54:37 +0300
- Subject: [PATCH] Remove perror() from archive.c
Hi,
Although I don't see any calls to bfd_perror() in the bfd, I think it is
better than perror(). Comments?
bfd/ChangeLog
2002-10-20 Elias Athanasopoulos <eathan@otenet.gr>
* archive.c (_bfd_archive_bsd_update_armap_timestamp): Replace
perror() with bfd_perror().
--- archive.c.orig Sun Oct 20 16:30:52 2002
+++ archive.c Sun Oct 20 16:45:12 2002
@@ -2082,7 +2082,7 @@ _bfd_archive_bsd_update_armap_timestamp
bfd_flush (arch);
if (bfd_stat (arch, &archstat) == -1)
{
- perror (_("Reading archive file mod timestamp"));
+ bfd_perror (_("Reading archive file mod timestamp"));
/* Can't read mod time for some reason. */
return true;
@@ -2108,8 +2108,7 @@ _bfd_archive_bsd_update_armap_timestamp
|| (bfd_bwrite (hdr.ar_date, (bfd_size_type) sizeof (hdr.ar_date), arch)
!= sizeof (hdr.ar_date)))
{
- /* FIXME: bfd can't call perror. */
- perror (_("Writing updated armap timestamp"));
+ bfd_perror (_("Writing updated armap timestamp"));
/* Some error while writing. */
return true;