This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: PATCH: Fix mips' support_64bit_objects
- From: Daniel Jacobowitz <drow at mvista dot com>
- To: "H. J. Lu" <hjl at lucon dot org>
- Cc: binutils at sources dot redhat dot com
- Date: Tue, 5 Nov 2002 16:50:18 -0500
- Subject: Re: PATCH: Fix mips' support_64bit_objects
- References: <20021101151143.A2007@lucon.org>
Are you still planning to check in this patch?
On Fri, Nov 01, 2002 at 03:11:43PM -0800, H. J. Lu wrote:
> I will check in the following patch shortly for
>
> http://sources.redhat.com/ml/bug-binutils/2002-q4/msg00049.html
>
>
> H.J.
> ---
> 2002-11-01 H.J. Lu <hjl@gnu.org>
>
> * config/tc-mips.c (support_64bit_objects): Check *l before it
> is freed.
>
> --- gas/config/tc-mips.c.64 Fri Nov 1 10:33:16 2002
> +++ gas/config/tc-mips.c Fri Nov 1 15:01:07 2002
> @@ -10174,6 +10174,7 @@ md_number_to_chars (buf, val, n)
> static int support_64bit_objects(void)
> {
> const char **list, **l;
> + int yes;
>
> list = bfd_target_list ();
> for (l = list; *l != NULL; l++)
> @@ -10186,8 +10187,9 @@ static int support_64bit_objects(void)
> || strcmp (*l, "elf64-littlemips") == 0)
> #endif
> break;
> + yes = (*l != NULL);
> free (list);
> - return (*l != NULL);
> + return yes;
> }
> #endif /* OBJ_ELF */
>
>
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer