This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: (hppa-linux) simple testcase for binutils visibility problem
- From: "John David Anglin" <dave at hiauly1 dot hia dot nrc dot ca>
- To: randolph at tausq dot org
- Cc: binutils at sources dot redhat dot com
- Date: Thu, 21 Nov 2002 14:14:02 -0500 (EST)
- Subject: Re: (hppa-linux) simple testcase for binutils visibility problem
Installed on head.
I am convinced that the remaining problems in the ld visibility testsuite
on hppa-linux are caused by unrelated problems. Function pointers are not
being correctly compared and the test program may be incorrect.
See <http://gcc.gnu.org/ml/gcc/2002-11/msg00819.html>.
> Can you test this patch? I've tested it on hppa-linux and the regression
> tests look a little better than before.
>
> randolph
> --
> Randolph Chung
> Debian GNU/Linux Developer, hppa/ia64 ports
> http://www.tausq.org/
>
> diff -uNrp binutils-2.13.90.0.4.orig/gas/config/tc-hppa.h binutils-2.13.90.0.4/gas/config/tc-hppa.h
> --- binutils-2.13.90.0.4.orig/gas/config/tc-hppa.h 2002-07-17 11:38:29.000000000 -0700
> +++ binutils-2.13.90.0.4/gas/config/tc-hppa.h 2002-11-13 20:55:13.000000000 -0800
> @@ -177,7 +177,8 @@ int hppa_fix_adjustable PARAMS((struct f
>
> #define tc_frob_symbol(sym,punt) \
> { \
> - if ((S_GET_SEGMENT (sym) == &bfd_und_section && ! symbol_used_p (sym)) \
> + if ((S_GET_SEGMENT (sym) == &bfd_und_section && ! symbol_used_p (sym) && \
> + ELF_ST_VISIBILITY (S_GET_OTHER (sym)) == STV_DEFAULT) \
> || (S_GET_SEGMENT (sym) == &bfd_abs_section \
> && ! S_IS_EXTERNAL (sym)) \
> || strcmp (S_GET_NAME (sym), "$global$") == 0 \
>
Dave
--
J. David Anglin dave.anglin@nrc.ca
National Research Council of Canada (613) 990-0752 (FAX: 952-6605)