This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Fix ia64 ld bootstrap test

On Wed, Dec 04, 2002 at 01:55:13PM -0800, H. J. Lu wrote:
> I was wondering the same thing. Shouldn't 
> 
>   len = sizeof (sec->id)*2 + 1 + sizeof (bfd_vma)*2 + 1;
> 
> be enough for
> 
>   sprintf (addr_name, "%x:%lx",

Yes, but since the sprintf is printing an unsigned long, I'd be
inclined to use sizeof (unsigned long) * 2 rather than
sizeof (bfd_vma)*2.  Note spaces around multiply operator.
OK with those changes.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]