This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
objdump configure patch for IA-64 gas opc-x testsuite failure
- From: Jim Wilson <wilson at redhat dot com>
- To: binutils at sources dot redhat dot com
- Date: 05 Dec 2002 13:36:10 -0500
- Subject: objdump configure patch for IA-64 gas opc-x testsuite failure
- References: <15844.31235.379621.794480@napali.hpl.hp.com><xwulm35jinn.fsf@tonopah.toronto.redhat.com>
This fixes the gas opc-x testsuite failure I am seeing, which is due to an
objdump bug. Objdump is replacing a sequence of 8 zeros with "...". This
accidentally causes the bundle addresses to be offset by 2 bytes, which then
causes us to print two garbage bytes past the end of file. This is fixed by
setting SKIP_ZEROES to 16 which is the bundle size, so that we only skip entire
bundles. This requires regenerating the opc-x.d file. The new opc-x.d file
has the same hex bytes and same disassembled instructions. The only difference
is that the off by 2 problem is fixed.
I have checked in this patch.
binutils/ChangeLog
2002-12-05 Jim Wilson <wilson@redhat.com>
* configure.in (OBJDUMP_DEFS): Define SKIP_ZEROES as 16 for IA-64.
* configure: Regenerate.
gas/testsuite/ChangeLog
2002-12-05 Jim Wilson <wilson@redhat.com>
* gas/ia64/opc-x.d: Regenerate.
Index: binutils/configure
===================================================================
RCS file: /cvs/src/src/binutils/configure,v
retrieving revision 1.48
diff -p -r1.48 configure
*** binutils/configure 7 Nov 2002 08:45:24 -0000 1.48
--- binutils/configure 5 Dec 2002 17:12:05 -0000
*************** do
*** 5567,5572 ****
--- 5567,5575 ----
c4x-*-* | tic4x-*-*)
OBJDUMP_DEFS="$OBJDUMP_DEFS -DSKIP_ZEROES=32"
;;
+ ia64-*-*)
+ OBJDUMP_DEFS="$OBJDUMP_DEFS -DSKIP_ZEROES=16"
+ ;;
esac
fi
done
Index: binutils/configure.in
===================================================================
RCS file: /cvs/src/src/binutils/configure.in,v
retrieving revision 1.37
diff -p -r1.37 configure.in
*** binutils/configure.in 7 Nov 2002 08:45:24 -0000 1.37
--- binutils/configure.in 5 Dec 2002 17:12:05 -0000
*************** changequote([,])dnl
*** 287,292 ****
--- 287,295 ----
c4x-*-* | tic4x-*-*)
OBJDUMP_DEFS="$OBJDUMP_DEFS -DSKIP_ZEROES=32"
;;
+ ia64-*-*)
+ OBJDUMP_DEFS="$OBJDUMP_DEFS -DSKIP_ZEROES=16"
+ ;;
esac
fi
done
Index: gas/testsuite/gas/ia64/opc-x.d
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/ia64/opc-x.d,v
retrieving revision 1.2
diff -p -r1.2 opc-x.d
*** gas/testsuite/gas/ia64/opc-x.d 5 Dec 2002 02:08:01 -0000 1.2
--- gas/testsuite/gas/ia64/opc-x.d 5 Dec 2002 17:12:06 -0000
*************** Disassembly of section .text:
*** 7,38 ****
0000000000000000 <_start>:
0: 04 00 00 00 01 00 \[MLX\] nop\.m 0x0
! ...
! e: 00 00 04 00 break\.x 0x0
! 12: 00 00 01 c0 ff ff \[MLX\] nop\.m 0x0
! 18: ff ff 7f e0 ff ff break\.x 0x3fffffffffffffff
! 1e: 01 08 04 00
! 22: 00 00 01 00 00 00 \[MLX\] nop\.m 0x0
! 28: 00 00 00 00 00 00 nop\.x 0x0
! 2e: 04 00 04 00
! 32: 00 00 01 c0 ff ff \[MLX\] nop\.m 0x0
! 38: ff ff 7f e0 ff ff nop\.x 0x3fffffffffffffff
! 3e: 05 08 04 00
! 42: 00 00 01 00 00 00 \[MLX\] nop\.m 0x0
! 48: 00 00 00 80 00 00 movl r4=0x0
! 4e: 00 60 04 00
! 52: 00 00 01 c0 ff ff \[MLX\] nop\.m 0x0
! 58: ff ff 7f 80 f0 f7 movl r4=0xffffffffffffffff
! 5e: ff 6f 04 00
! 62: 00 00 01 80 90 78 \[MLX\] nop\.m 0x0
! 68: 56 34 12 80 f0 76 movl r4=0x1234567890abcdef
! 6e: 6d 66 04 00
! 72: 00 00 01 00 00 00 \[MLX\] nop\.m 0x0
! 78: 00 00 00 00 00 00 hint\.x 0x0
! 7e: 06 00 04 00
! 82: 00 00 01 00 00 00 \[MLX\] nop\.m 0x0
! 88: 00 00 00 00 00 00 hint\.x 0x0
! 8e: 06 00 05 00
! 92: 00 00 01 c0 ff ff \[MLX\] nop\.m 0x0
! 98: ff ff 7f e0 ff ff hint\.x 0x3fffffffffffffff;;
! 9e: 07 08 00 00
--- 7,38 ----
0000000000000000 <_start>:
0: 04 00 00 00 01 00 \[MLX\] nop\.m 0x0
! 6: 00 00 00 00 00 00 break\.x 0x0
! c: 00 00 00 00
! 10: 04 00 00 00 01 c0 \[MLX\] nop\.m 0x0
! 16: ff ff ff ff 7f e0 break\.x 0x3fffffffffffffff
! 1c: ff ff 01 08
! 20: 04 00 00 00 01 00 \[MLX\] nop\.m 0x0
! 26: 00 00 00 00 00 00 nop\.x 0x0
! 2c: 00 00 04 00
! 30: 04 00 00 00 01 c0 \[MLX\] nop\.m 0x0
! 36: ff ff ff ff 7f e0 nop\.x 0x3fffffffffffffff
! 3c: ff ff 05 08
! 40: 04 00 00 00 01 00 \[MLX\] nop\.m 0x0
! 46: 00 00 00 00 00 80 movl r4=0x0
! 4c: 00 00 00 60
! 50: 04 00 00 00 01 c0 \[MLX\] nop\.m 0x0
! 56: ff ff ff ff 7f 80 movl r4=0xffffffffffffffff
! 5c: f0 f7 ff 6f
! 60: 04 00 00 00 01 80 \[MLX\] nop\.m 0x0
! 66: 90 78 56 34 12 80 movl r4=0x1234567890abcdef
! 6c: f0 76 6d 66
! 70: 04 00 00 00 01 00 \[MLX\] nop\.m 0x0
! 76: 00 00 00 00 00 00 hint\.x 0x0
! 7c: 00 00 06 00
! 80: 04 00 00 00 01 00 \[MLX\] nop\.m 0x0
! 86: 00 00 00 00 00 00 hint\.x 0x0
! 8c: 00 00 06 00
! 90: 05 00 00 00 01 c0 \[MLX\] nop\.m 0x0
! 96: ff ff ff ff 7f e0 hint\.x 0x3fffffffffffffff;;
! 9c: ff ff 07 08