This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH/RFC] NULL terminate mips dis options

From: Eric Christopher <echristo at redhat dot com>
To: Elias Athanasopoulos <elathan at phys dot uoa dot gr>
Cc: cgd at broadcom dot com, binutils at sources dot redhat dot com
Date: 10 Feb 2003 11:23:11 -0800
Subject: Re: [PATCH/RFC] NULL terminate mips dis options
References: <20030210123901.V8236@neutrino.particles.org><mailpost.1044873647.4282@news-sj1-1> <yov5bs1kf1fe.fsf@broadcom.com> <20030210211434.B8236@neutrino.particles.org>

Hi Elias,

> > You should convert the uses of them in print_mips_disassembler_options
> > to use ARRAY_SIZE as other uses do.  That would be the correct patch.
> 
> 
> 2003-02-10  Elias Athanasopoulos  <elathan@phys.uoa.gr>
> 
> 	* mip-dis.c (print_mips_disassembler_options): Make 'i' usnigned,
> 	use the size of mips_abi_choices, mips_arch_choices in loops.
> 
> 

Unfortunately you didn't use ARRAY_SIZE as Chris had suggested. Could
you please do that and send again?

Thanks for your effort.

-eric

-- 
guess, feel, botch, puzzle, try again,
and try to remember what you did.

Follow-Ups:
- Re: [PATCH/RFC] NULL terminate mips dis options
  - From: Elias Athanasopoulos

References:
- [PATCH/RFC] NULL terminate mips dis options
  - From: Elias Athanasopoulos
- Re: [PATCH/RFC] NULL terminate mips dis options
  - From: cgd
- Re: [PATCH/RFC] NULL terminate mips dis options
  - From: Elias Athanasopoulos

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]