This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] space register 0 changes for hppa
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: Matthew Wilcox <willy at debian dot org>
- Cc: binutils at sources dot redhat dot com, parisc-linux at parisc-linux dot org
- Date: Mon, 24 Feb 2003 16:54:21 +1030
- Subject: Re: [PATCH] space register 0 changes for hppa
- References: <20030223185847.C2938@parcelfarce.linux.theplanet.co.uk>
On Sun, Feb 23, 2003 at 06:58:47PM +0000, Matthew Wilcox wrote:
> + * hppa-dis.c: Do not emit a space register if the space register
> + field is 2 bits and the value is 0 as this is implicit addressing,
> + not use of space register 0.
Hi Matthew,
ChangeLog entries shouldn't be sent as diffs. Write this one as
* hppa-dis.c (print_insn_hppa <2 bit space register>): Do not print
the space register when the value is zero.
and put the reason for the change as a comment in the code if you feel
you need some justification for the change.
Did you run the binutils testsuite?
--
Alan Modra
IBM OzLabs - Linux Technology Centre