Re: windres: serious bug

[Danny Smith <dannysmith at clear dot net dot nz>]

----- Original Message -----
From: "Nick Clifton"

> The patch appears to work and it does not break anything, so I am
> applying it, together with a new test for the testsuite to check that
> the fix works.
>
> Cheers
> Nick
>
> PS.  I created the dialogid.rsd file using windres rather than
> Window's resource compiler because I do not have access to a Windows
> build system.  If anyone does have such access and can check that the
> compiled dialogid.rc file really does match with the one I created,
> (modulo the "Static" discrepancy), I would be very grateful.
>
 I can confirm that.
If you change "Static" to "classname" in the testcase, than the rc vs
windres dumps are identical.


Danny

>
> binutils/ChangeLog
> 2003-03-31  Ian Lance Taylor <ian at airs dot com>
>
> * rcparse.y: Replace uses of 'optstringrc' with 'optresid'.
> (optresid): Handle a resource id that can be a string or a number.
> * resrc.c (define_control): Replace 'text' parameter with 'iid' a
> struct res_id.
> (define_icon_control): Pass a struct res_id to define_control.
> * windres.h (define_control): Change prototype.
>
> binutils/testsuite/ChangeLog
> 2003-03-31  Nick Clifton  <nickc at redhat dot com>
>
> * binutils-all/windres/dialogid.rc: New test source file.
> * binutils-all/windres/dialogid.rsd: New test expected results.
>