This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: Patch to fix regenerating libiberty/config.in
- From: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- To: ebotcazou at libertysurf dot fr
- Cc: binutils at sources dot redhat dot com, dj at redhat dot com, gcc-patches at gcc dot gnu dot org, gdr at integrable-solutions dot net
- Date: Sat, 12 Apr 2003 17:37:23 -0400 (EDT)
- Subject: Re: Patch to fix regenerating libiberty/config.in
- References: <200302121958.OAA06795@caip.rutgers.edu> <200304101258.26650.ebotcazou@libertysurf.fr> <200304122053.05252.ebotcazou@libertysurf.fr>
> From: Eric Botcazou <ebotcazou at libertysurf dot fr>
>
> > > 2003-02-12 Kaveh R. Ghazi <ghazi at caip dot rutgers dot edu>
> > >
> > > * acconfig.h: New file. Add uintptr_t.
> > > * config.in: Regenerated.
> >
> > This patch breaks bootstrap on sparc-sun-solaris2.5.1:
> >
> > "../src/libiberty/regex.c", line 305: invalid type combination
> > "../src/libiberty/regex.c", line 305: warning: useless declaration
> > "../src/libiberty/regex.c", line 305: warning: typedef declares no type
> > name
>
> The 3.2.3 release is approaching so I think it would be nice to fix the
> bootstrap failure quickly.
>
>
> The problem is pretty obvious: config.h contains these lines
>
> /* Define to `unsigned long' if <sys/types.h> doesn't define. */
> #define uintptr_t unsigned long
>
> /* Define if you have the `uintptr_t' type. */
> /* #undef HAVE_UINTPTR_T */
>
> and regex.c contains these lines
>
> # if !defined _LIBC && !defined HAVE_UINTPTR_T
> typedef unsigned long int uintptr_t;
> # endif
>
> so there is a conflict. Reverting the patch or removing the typedef appears
> to be sufficient to restore bootstrap, but I don't know enough libiberty to
> decide which solution is the best/safest. Thanks in advance for your help.
> Eric Botcazou
Sorry for the trouble. I'll be able to take a look tomorrow (Sunday.)
--Kaveh
--
Kaveh R. Ghazi ghazi at caip dot rutgers dot edu