This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] Fix objdump -R internal error on prelinked binaries
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: Julien LEMOINE <speedblue at debian dot org>
- Cc: binutils at sources dot redhat dot com
- Date: Wed, 23 Apr 2003 14:52:08 +0930
- Subject: Re: [PATCH] Fix objdump -R internal error on prelinked binaries
- References: <200304230357.44420.speedblue@debian.org>
On Wed, Apr 23, 2003 at 03:57:44AM +0200, Julien LEMOINE wrote:
> Here is a new one, wich does not break RELA targets.
Thanks. I applied this equivalent patch.
From Julien LEMOINE <speedblue at debian dot org>
* elf32-i386.c (elf_i386_info_to_howto): Delete.
(elf_info_to_howto): Define as elf_i386_info_to_howto_rel.
Index: bfd/elf32-i386.c
===================================================================
RCS file: /cvs/src/src/bfd/elf32-i386.c,v
retrieving revision 1.96
diff -u -p -r1.96 elf32-i386.c
--- bfd/elf32-i386.c 6 Mar 2003 23:26:20 -0000 1.96
+++ bfd/elf32-i386.c 23 Apr 2003 05:04:51 -0000
@@ -26,8 +26,6 @@
static reloc_howto_type *elf_i386_reloc_type_lookup
PARAMS ((bfd *, bfd_reloc_code_real_type));
-static void elf_i386_info_to_howto
- PARAMS ((bfd *, arelent *, Elf_Internal_Rela *));
static void elf_i386_info_to_howto_rel
PARAMS ((bfd *, arelent *, Elf_Internal_Rela *));
static bfd_boolean elf_i386_is_local_label_name
@@ -373,15 +371,6 @@ elf_i386_reloc_type_lookup (abfd, code)
}
static void
-elf_i386_info_to_howto (abfd, cache_ptr, dst)
- bfd *abfd ATTRIBUTE_UNUSED;
- arelent *cache_ptr ATTRIBUTE_UNUSED;
- Elf_Internal_Rela *dst ATTRIBUTE_UNUSED;
-{
- abort ();
-}
-
-static void
elf_i386_info_to_howto_rel (abfd, cache_ptr, dst)
bfd *abfd ATTRIBUTE_UNUSED;
arelent *cache_ptr;
@@ -3367,7 +3356,8 @@ elf_i386_finish_dynamic_sections (output
#define elf_backend_got_header_size 12
#define elf_backend_plt_header_size PLT_ENTRY_SIZE
-#define elf_info_to_howto elf_i386_info_to_howto
+/* Support RELA for objdump of prelink objects. */
+#define elf_info_to_howto elf_i386_info_to_howto_rel
#define elf_info_to_howto_rel elf_i386_info_to_howto_rel
#define bfd_elf32_mkobject elf_i386_mkobject
--
Alan Modra
IBM OzLabs - Linux Technology Centre