This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: RFA: Fix MIPS failure for ld-elf/merge test
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: binutils at sources dot redhat dot com
- Date: Mon, 5 May 2003 15:30:34 +0930
- Subject: Re: RFA: Fix MIPS failure for ld-elf/merge test
- References: <20030504214556.GA14722@nevyn.them.org>
On Sun, May 04, 2003 at 05:45:56PM -0400, Daniel Jacobowitz wrote:
> The fix is in two parts. The first one: in a patch last year, Richard
> Sandiford changed mips_need_elf_addend_fixup to check SEC_MERGE. However,
> he left it conditioned on symbol_useed_in_reloc_p. That's relevant (?? I
> think? Maybe it shouldn't be there at all?) to the SEC_LINK_ONCE check; but
> it doesn't matter for SEC_MERGE. If I move the SEC_MERGE check out to a
> separate if statement, the offset drops from 0x10 to 0xc.
symbol_used_in_reloc_p should be removed. The flag isn't set
early enough for md_apply_fix3.
--
Alan Modra
IBM OzLabs - Linux Technology Centre