This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: RFA: A small mips gas patch
On Mon, May 05, 2003 at 03:16:13PM -0700, Eric Christopher wrote:
> On Sun, 2003-05-04 at 16:36, H. J. Lu wrote:
> > I am trying to push out all my local changes. One of them is
> >
> > http://sources.redhat.com/ml/binutils/2003-03/msg00177.html
> >
> > Could someone please approve or disapprove it?
>
> I don't think it really makes sense - at least not without seeing what
> it's fixing. We're adding that back in there since we subtracted it
> twice in md_apply_fix3...
>
It will be subtracted twice only if howto->partial_inplace is true. In
md_apply_fix3, there are
value -= symval;
howto = bfd_reloc_type_lookup (stdoutput, fixP->fx_r_type);
if (value != 0 && howto && howto->partial_inplace
^^^^^^^^^^^^^^^^^^^^^
&& (! fixP->fx_pcrel || howto->pcrel_offset))
{
...
value -= symval;
...
}
If howto->partial_inplace is false, it will be only subtracted once.
Did I miss something here?
H.J.