This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] to avoid objdump hangs


Hi Salvador,

> This is my first post to the list, sorry if I'm doing in the wrong
> way.

  The patch was fine.  There were two problems however:

    1.  You omitted to include an entry for the ChangeLog describing
        the patch.  (I have generated one for you this time).

    2.  You do not have a copyright assignment on file with the FSF.
        (Well not for binutils contribution anyway).  In general we
        cannot accept patches or other contributions without such an
        assignment.  In the case of this particular patch however I
        feel that it falls into the "simple and obvious" category and
        so is exempt from the copyright assignment requirement.

        
> Index: debug.c
> ===================================================================
> RCS file: /cvs/src/src/binutils/debug.c,v
> retrieving revision 1.9
> diff -u -r1.9 debug.c
> --- debug.c     13 Feb 2003 10:32:46 -0000      1.9
> +++ debug.c     2 May 2003 14:37:06 -0000
> @@ -2183,7 +2183,7 @@
>
>     for (l = list; l != NULL; l = l->next)
>       {
> -      if (l->t == type)
> +      if (l->t == type || l == l->next)
>          {
>            fprintf (stderr,
>                     _("debug_get_real_type: circular debug information
> for %s\n"),

Thank you for submitting this patch.  I have applied it to the
sources.

Cheers
        Nick


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]