This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: PATCH: don't sign-extend address in ihex files
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: Jim Blandy <jimb at redhat dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Wed, 14 May 2003 18:43:11 +0930
- Subject: Re: PATCH: don't sign-extend address in ihex files
- References: <vt27k8ubon6.fsf@zenia.red-bean.com>
On Tue, May 13, 2003 at 03:03:09PM -0500, Jim Blandy wrote:
> Since the value of the hex_value
> macro (defined in libiberty.h) is signed
Except when char is unsigned, which is another argument in favour of
your patch.
> 2003-05-07 Jim Blandy <jimb@redhat.com>
>
> * ihex.c (NIBBLE): Make this unsigned, to avoid sign-extension
> when the value of a HEX2 or HEX4 application gets stored in a
> 64-bit bfd_vma.
OK.
--
Alan Modra
IBM OzLabs - Linux Technology Centre