This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] Fix _bfd_elf_link_renumber_dynsyms return value
- From: Daniel Jacobowitz <drow at mvista dot com>
- To: Thiemo Seufer <ica2_ts at csv dot ica dot uni-stuttgart dot de>
- Cc: binutils at sources dot redhat dot com
- Date: Mon, 26 May 2003 17:03:55 -0400
- Subject: Re: [PATCH] Fix _bfd_elf_link_renumber_dynsyms return value
- References: <20030525113853.GF5022@rembrandt.csv.ica.uni-stuttgart.de>
On Sun, May 25, 2003 at 01:38:54PM +0200, Thiemo Seufer wrote:
> Hello All,
>
> this patch fixes _bfd_elf_link_renumber_dynsyms to actually return
> the dynsymcount value.
>
> I'm a bit surprised that this bug wasn't more visible.
>
>
> Thiemo
Are you sure this patch does anything? The value of "a = b" is the
value of b.
> 2003-05-25 Thiemo Seufer <seufer@csv.ica.uni-stuttgart.de>
>
> /bfd/ChangeLog
> * elflink.c (_bfd_elf_link_renumber_dynsyms): Actually return the
> dynsymcount.
>
>
> --- source-orig/bfd/elflink.c Sun May 25 09:20:22 2003
> +++ source/bfd/elflink.c Sun May 25 10:12:52 2003
> @@ -668,7 +668,9 @@ _bfd_elf_link_renumber_dynsyms (output_b
> if (dynsymcount != 0)
> ++dynsymcount;
>
> - return elf_hash_table (info)->dynsymcount = dynsymcount;
> + elf_hash_table (info)->dynsymcount = dynsymcount;
> +
> + return dynsymcount;
> }
>
> /* This function is called when we want to define a new symbol. It
>
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer