This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] use mkstemp instead of mktemp.


On Tue, Jul 01, 2003 at 09:11:27PM -0700, Muthukumar Ratty wrote:
> >
> > You can't just mechanically replace mktemp() with mkstemp().  They
> > have different return values.
> >mkstemp() returns the newly opened
> > file.
> 
> and also modifies the template properly so I think it should be ok.

Note that blindly ignoring the return value of mkstemp() and then using
the modified template to open the file will create exactly the same race
condition that mkstemp() was designed to fix!  You'll remove the link
time warning, but not fixed the problem the warning was warning about.

Simon.
--
Simon Burge                                   <simonb@wasabisystems.com>
NetBSD Development, Support and Service:   http://www.wasabisystems.com/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]