This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] fix segfault on copying some PEs
- From: Nick Clifton <nickc at redhat dot com>
- To: Jeff Muizelaar <muizelaar at rogers dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Tue, 05 Aug 2003 09:18:29 +0100
- Subject: Re: [PATCH] fix segfault on copying some PEs
- References: <3F2D6843.9090904@rogers.com>
Hi Jeff,
> 2003-08-03 Jeff Muizelaar <muizelaar@rogers.com>
>
> * coffcode.h: (coff_slurp_line_table) fix read error causing segfault.
Approved and applied.
I did make two small changes to the patch:
1. I moved the test for a NULL native_lineno to before the
allocation of the lineno_cache. That way if the line number
table could not be read there will not be a memory leak for an
unused cache.
2. I changed the text in the ChangeLog entry to describe what was
being fixed, rather than just referring to an anonymous segfault.
Cheers
Nick