This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: Patches to move cgen files to C90 with prototypes
On Wed, Aug 06, 2003 at 05:23:33PM -0700, Doug Evans wrote:
> Michael Meissner writes:
> > 2003-08-06 Michael Meissner <gnu@the-meissners.org>
> >
> > ... massively large changelog entry,
> > ... especially for just a k&r -> c90 substitution
>
> fwiw, I think people think they're under far too much pressure to
> write anally correct changelog entries before a patch will get accepted.
I don't care one way or another, as I can rewrite it however people want. I do
recall it came up in GCC about a year ago, with people complaining that they
wanted to be able to grep for each function modified, and in particular didn't
want things like:
* ({put,get}_some_function): Blah, blah, blah.
> Nick, in this particular case, does one really have to mention every function?
> How about this instead?
>
> 2003-08-06 Michael Meissner <gnu@the-meissners.org>
>
> * cgen-dis.in (*): Remove PARAMS macro. Use void * instead of PTR.
> * cgen-ibld.in (*): Ditto.
> * cgen-asm.in (*): Ditto.
> * cgen-dis.c (*): Ditto.
> * cgen-opc.c (*): Ditto.
> * cgen-asm.c (*): Ditto.
I probably would do it as:
* cgen-dis.in: Remove PARAMS macro. Use void * instead of PTR. Fully
prototype all function definitions.
* cgen-ibld.in: Ditto.
...
ie, drop the (*).
> [N.B. I said "in this particular case". Don't try to generalize
> my comments too far ...]
--
Michael Meissner
email: gnu@the-meissners.org
http://www.the-meissners.org