Re: [PATCH] Add HP dwarf extensions to dwarf2.h

[Nick Clifton <nickc at redhat dot com>]

Hi James,

> Here is a patch which adds the dwarf definitions HP use on IA64
> HP-UX to binutils dwarf2.h.

This patch is mostly OK, and would not require a copyright assignment,
but...

...there are a few minor points:

  * You have not included DW_AT_HP_block_index and
    DW_AT_HP_unmodifiable.  (The overlap with DW_AT_MIPS_fde is not
    relevant).

  * The comments need to be reformatted to conform the GNU coding
    conventions.

  * You are including DW_ATE_lo_user in the enum dwarf_type, when it
    is already defined by a "#define" at the end of the declaration.

  * You are changing the names of the DW_ATE_... types.  You have
    added in an _HP which does not appear in the dwarf2.h file
    downloaded from HP's web site.  I approve of this change, but will
    it affect HP ?  Will they accept the name change ?  (If they care
    that is).

If you would care to make the modifications indicated for the first
three points and then resubmit the patch, I will probably accept it.

Cheers
        Nick