This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [patch] armbe-linux target defaults to big-endian
- From: Richard Earnshaw <rearnsha at arm dot com>
- To: David Vrabel <dvrabel at arcom dot com>
- Cc: binutils at sources dot redhat dot com, gcc-patches at gcc dot gnu dot org, Richard dot Earnshaw at arm dot com
- Date: Tue, 14 Oct 2003 11:45:09 +0100
- Subject: Re: [patch] armbe-linux target defaults to big-endian
- Organization: ARM Ltd.
- Reply-to: Richard dot Earnshaw at arm dot com
> Hi,
>
> The attached patches (for binutils 2.14 and GCC 3.3.1) add/fix the
> armbe-linux target so that big-endian code is generated by default.
>
> It works for what I want but I suspect it's not done properly.
>
:(
Nope, there's some cleaning up required.
Do you have a copyright assignment on file?
> case ${cpu} in
> alpha*) cpu_type=alpha ;;
> + arm*be|xscale*be|strongarm*be) cpu_type=arm endian=big ;;
> arm*b|xscale*b|strongarm*b) cpu_type=arm endian=big ;;
You should clearly be using a configuration of armb-<xxx>, then the code
is substantially there (see the line after your patch).
I think all the binutils code is already in the main CVS repository. It's
not normally worth reporting a patch against a branch unless it fixes a
specific bug.
> diff -urN gcc-3.3.1.orig/gcc/config/arm/be-linux-elf.h gcc-3.3.1/gcc/config/arm/be-linux-elf.h
Following the convention in binutils this should be "linux-elfb.h". Again
the patch should be against the trunk of the CVS repository.
> --- gcc-3.3.1.orig/gcc/config/arm/be-linux-elf.h 1970-01-01 01:00:00.000000000 +0100
> +++ gcc-3.3.1/gcc/config/arm/be-linux-elf.h 2003-10-03 11:07:04.000000000 +0100
> @@ -0,0 +1,42 @@
> +/* Definitions for ARM (big-endian) running Linux-based GNU systems using ELF
> + Copyright (C) 1993, 1994, 1997, 1998, 1999, 2000, 2001, 2002
It's 2003 now. Since this is a new file, you should remove the old dates.
> + Free Software Foundation, Inc.
> + Contributed by Philip Blundell <philb@gnu.org>
No, you are contributing it.
There are other updates as well, but they are all a consequence of the
above.
R.