This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

PATCH: Re: ld's --no-undefined-version and '*' in pattern


On Thu, Oct 16, 2003 at 05:34:47PM +0200, Jan Beulich wrote:
> Maybe I didn't express my desires clearly: if I have 
> 
> version_1.0 {
> global:
> 	abc*;
> 	def?;
> 	ghi[0-9];
> local:
> 	*;
> };
> 
> and the object files getting linked together do not contain symbols
> matching any of the three patterns, then I will get warnings (or are
> they errors?) on def? and ghi[0-9], but not on abc*. I'd like to get
> warnings on all of them if they never matched any symbol.
> 

Thanks. Here is a patch. I will check it in shortly.


H.J.
---
2003-10-16  H.J. Lu  <hongjiu.lu@intel.com>

	* elflink.h (NAME(bfd_elf,size_dynamic_sections)): Also warn
	undefined patterns with '*'.

--- bfd/elflink.h.undef	2003-10-14 17:19:56.000000000 -0700
+++ bfd/elflink.h	2003-10-16 09:21:27.000000000 -0700
@@ -2125,8 +2125,7 @@ NAME(bfd_elf,size_dynamic_sections) (bfd
 	  all_defined = TRUE;
 	  for (t = verdefs; t != NULL; t = t->next)
 	    for (d = t->globals; d != NULL; d = d->next)
-	      if (!d->symver && !d->script
-		  && strchr (d->pattern, '*') == NULL)
+	      if (!d->symver && !d->script)
 		{
 		  (*_bfd_error_handler)
 		    (_("%s: undefined version: %s"),


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]