This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: working TLS support, take 1


Hi Jonathan,

> Just got word from the GNU people that my assignment arrived.
> Can you check my TLS patch in now?

Yes.

A couple of pointers for future patches, should you make them:

  * Please include ChangeLog entry(s) for the changes you make.  I
    have generated them for you this time.

  * Please generate your patches using "diff -c3p" or "cvs diff -c3p"
    depending upon whether you use cvs.

  * When referring to a previously submitted patch including the URL
    for the mail message in the binutils mail archive is very helpful.

  * You patch included some text at the end that looked like it might
    have been intended to be a test case, but it was not documented or
    explained, so I have ignored it:


      .file "i386\\atlssup.asm"
          @comp.id:
          @comp.id = 0xe1c83
          __tls_array = 0x2c
          .globl __tls_array
      .text
      .data
      
      #include <windows.h>
      DWORD _tls_start __attribute__ ((section (".tls"))) = 0;
      DWORD _tls_end __attribute__ ((section (".tls$ZZZ"))) = 0;
      DWORD _tls_index = 0;
      PIMAGE_TLS_CALLBACK __xl_a __attribute__ ((section (".CRT$XLA"))) = 0;
      PIMAGE_TLS_CALLBACK __xl_z __attribute__ ((section (".CRT$XLZ"))) = 0;
      IMAGE_TLS_DIRECTORY _tls_used = {(DWORD)&_tls_start, (DWORD)&_tls_end, &_tls_index, &__xl_a, 0, 0};    

Cheers
        Nick

bfd/ChangeLog
2003-11-10  Jonathan Wilson <jonwil@tpgi.com.au>

	* peXXigen.c (_bfd_XXi_swap_aouthdr_out): Swap out tls pointer.
	(_bfd_XXi_final_link_postscript): Look for __tks_used symbol.  If
	found initialise the tls data directory entry.

ld/ChangeLog
2003-11-10  Jonathan Wilson <jonwil@tpgi.com.au>

	* scripttempl/pe.sc: Add support for TLS sections.

                


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]