This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [patch] Fix arm VFP2 insns
- From: Richard Earnshaw <rearnsha at arm dot com>
- To: Paul Brook <paul at codesourcery dot com>
- Cc: binutils at sources dot redhat dot com, Richard Earnshaw <rearnsha at arm dot com>, Mark Mitchell <mark at codesourcery dot com>
- Date: Fri, 09 Jan 2004 11:36:18 +0000
- Subject: Re: [patch] Fix arm VFP2 insns
- Organization: ARM Ltd.
- Reply-to: Richard dot Earnshaw at arm dot com
> Patch below fixes the arm additional vfp2 opcodes (fmdrr, fmrrd, fmsrr and
> fmrrs) and adds corresponding testcase.
>
> It also rearranges the disassembly patterns so these are used in preference to
> the generic mcrr opcode.
>
> Ok?
>
> Paul
>
> 2004-01-09 Paul Brook <paul@codesourcery.com>
>
> * gas/config/tc-arm.c (do_vfp_reg_from_sp2): Rename from do_vfp_sp_reg2.
> (do_vfp_sp_from_reg2): New function.
> (insns): Use them.
> (do_vfp_dp_from_reg2): Check return values properly.
> * gas/testsuite/gas/arm/vfp2.s, gas/arm/vfp2.d: New test.
> * gas/testsuite/gas/arm/arm.exp: Add them.
> * opcodes/arm-opc.h (arm_opcodes): Move generic mcrr after known
> specific opcodes.
Ok. If you want to be strictly accurate, then the functions should
probably be called do_vfp_reg2_from_sp2 and do_vfp_sp2_from_reg2 (there's
two registers read and two written in both cases).
R.