This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] Re: [Mingw-users] binutils 20040120-1 & VC6 .lib incompatibility?


 --- Danny Smith wrote: >
  --- cls wrote: > 
>We're noticing a problem when building Mozilla using the latest
> mingw
> > binutils release candidate.  We have old versions of libIDL-0.6.lib &
> > glib-1.2.lib which are linked into the xpidl.exe binary. The libraries
> > were built back in 2001 using VC6 SP??? . If xpidl is built using binutils
> > 20040120-1, then xpidl will crash when attempting to call into the libIDL
> > library.  
> 
> Are the VC6-built libraries dlls/import libs?  What is the error messsage?
> 

Hi, 

The regression reported here:

http://mail.gnu.org/archive/html/bug-binutils/2004-01/msg00053.html

was caused by this patch:

2003-12-18  Eric Youngdale  <eric@mkssoftware.com>
            Nick Clifton  <nickc@redhat.com>

	* emultempl/pe.em (_after_open): When scanning MS import
	libraries allow for the possible presence of static objects.


The following fixes in my tests:

ld/ChangeLog

2004-02-04  Danny Smith  <dannysmith@users.sourceforge.net>

	* emultempl/pe.em (_after_open): Fix thinko in 2003-12-18 patch.


Index: emultempl/pe.em
===================================================================
RCS file: /cvs/src/src/ld/emultempl/pe.em,v
retrieving revision 1.87
diff -c -3 -p -r1.87 pe.em
*** emultempl/pe.em	3 Jan 2004 12:39:07 -0000	1.87
--- emultempl/pe.em	3 Feb 2004 10:37:46 -0000
*************** gld_${EMULATION_NAME}_after_open (void)
*** 1139,1146 ****
  		       extension, and use that for the remainder of the
  		       comparisons.  */
  		    pnt = strrchr (is3->the_bfd->filename, '.');
! 		    if (pnt != NULL && strcmp (pnt, ".dll") != 0)
! 		      continue;
  		  }
  
  		if (is3 == NULL)
--- 1139,1146 ----
  		       extension, and use that for the remainder of the
  		       comparisons.  */
  		    pnt = strrchr (is3->the_bfd->filename, '.');
! 		    if (pnt != NULL && strcmp (pnt, ".dll") == 0)
! 		      break;
  		  }
  
  		if (is3 == NULL)

> 
> Danny
> > 
> > - cls
> 
> 
> http://greetings.yahoo.com.au - Yahoo! Greetings
> Send your love online with Yahoo! Greetings - FREE!
>  

http://greetings.yahoo.com.au - Yahoo! Greetings
Send your love online with Yahoo! Greetings - FREE!


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]