Re: telling symbols defined only in the linker script

[Nick Clifton <nickc at redhat dot com>]

Hi Alex,

>>> +#if 0
>>> +  /* These are set in _frv_count_got_plt_entries() or later, and this
>>> +     function is only called in _frv_resolve_final_relocs_info(), that
>>> +     runs just before it, so we don't have to worry about the fields
>>> +     below.  */
>
>> What is the point of adding suppressed code ?  If you want it there
>> for future enablement or debugging purposes then there should at least
>> be comment explaining this.
>
> Err...  Isn't it already sufficiently explained in the comment above?
> Or am I missing your point?

NO - I am just being stupid.  Sorry :-(

>> On similar grounds I would prefer not to see BFD_ASSERTs added to the
>> code.
>
> BFD_ASSERT doesn't abort either; it just prints a warning message.  It
> doesn't interrupt the linking, prevent the output from being produced
> nor even product an failure status.

Indeed - me being stupid again.

Please consider this patch approved.

Cheers
        Nick