This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On Tue, 9 Mar 2004, Richard Earnshaw wrote: > > On Mon, 8 Mar 2004, Richard Earnshaw wrote: > This is a *vast* improvement. There's a couple of minor technical > niggles, where you haven't conformed to the GNU coding standards, and > there's no ChangeLog entry. But other than that, I think this is OK now. > > It would also be good if there were test cases added to the regression > suite to check ensure that we don't break things again in future. > > > Bruno > > > > PS: > > > > I applied for a copyright assignment (but the patch is really small, even > > smaller than the first one) > > This is Nick's call. I'd err on the side of caution and ask for one, but > as lead maintainer, Nick might be prepared to let this one through. If I receive the papers I will sign them. > Please can you fix up the niggles, add a ChangeLog entry and re-send the > diff using "diff -p" format. done... And I incorporated your remarks... Thanks for that... Bruno > General: in all cases there should be a space between the function name > and the opening parenthesis for the arguments/parameters. > > foo () > never > foo() > > > > > > -static void > > -mapping_state (enum mstate state) > > +static enum mstate mapstate = MAP_UNDEFINED; > > + > > +static void mapping_state (enum mstate state) > > Function name on a new line. > > > { > > - static enum mstate mapstate = MAP_DATA; > > symbolS * symbolP; > > const char * symname; > > int type; > > @@ -2933,10 +2926,15 @@ > > symname = "$t"; > > type = BSF_FUNCTION; > > break; > > + case MAP_UNDEFINED: > > + return; > > + > > blank line before new case statement. > > > @@ -3111,6 +3100,9 @@ > > > > /* Align pool as you have word accesses. > > Only make a frag if we have to. */ > > + > > + > > + mapping_state(MAP_DATA); > > excess blank lines between comment and code. In fact, this comment is now > divorced from the code it refers to. Please rearrange that. > > > if (!need_pass_2) > > frag_align (2, 0, 0); > > > > +enum mstate > > +{ > > + MAP_UNDEFINED=0, /* Must be zero, for seginfo in new sections */ > > White space around '=' > > R. >
Attachment:
gas_arm_mapping.patch
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |