This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: Patch ping: multiple -o options
- From: Ian Lance Taylor <ian at wasabisystems dot com>
- To: Nathan Sidwell <nathan at codesourcery dot com>
- Cc: binutils at sources dot redhat dot com
- Date: 25 Mar 2004 08:39:03 -0500
- Subject: Re: Patch ping: multiple -o options
- References: <4062995B.9050101@codesourcery.com>
Nathan Sidwell <nathan@codesourcery.com> writes:
> http://sources.redhat.com/ml/binutils/2004-03/msg00137.html
>
> In fixing GCC PR driver/13577, I discovered both gas and ld silently
> allow multiple -o options. This patch fixes that.
>
> Tested on i686-pc-linux-gnu, and manually for multiple -o usage
>
> ok?
I think the code in lang_add_output() is too tricky. I think a future
maintainer is going to have to read that several times to figure out
what is happening, especially given that from_script has type int.
Really the from_script parameter should be bfd_boolean.
The patch to gas is OK.
Ian