This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch to properly assemble/disassemble ColdFire MAC/EMAC instructions


Hi Peter,

This is a repost of the patch with change in m68k-parse.y to fix a
missing ')'.



This is fine, but please could you:


1) Supply ChangeLogs for each subdirectory (ie bfd, gas, include/opcode, opcodes) detailing what the patch does there.

2) Fix up the formatting in the comments to follow the GNU coding standard.

3) Supply a test case to be added to gas/testsuites/gas/m68k/ to test the new instructions.

4) Add a patch to the gas/NEWS file mentioning the support for the new instructions.

Thanks very much.

Cheers
 Nick


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]