This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: PATCH: Return NULL on NULL bfd (Problem with linker with binutils-040414)
Hi Guys,
OK - well at some point we need to reach a decision on which solution
to choose, and since I am the maintainer I get to make the choice
:-). So I say that we go with b_a_f() returning NULL. It may not
please everyone but it is still what I believe to be the best compromise.
To that end I have applied this patch to bfd.c.
Cheers
Nick
bfd/ChangeLog
2004-04-22 Nick Clifton <nickc@redhat.com>
* bfd.c (bfd_archive_filename): Return NULL on NULL input.
Index: bfd.c
===================================================================
RCS file: /cvs/src/src/bfd/bfd.c,v
retrieving revision 1.57
retrieving revision 1.58
diff -c -3 -p -r1.57 -r1.58
*** bfd.c 21 Apr 2004 17:05:11 -0000 1.57
--- bfd.c 22 Apr 2004 10:43:34 -0000 1.58
*************** const char *
*** 509,515 ****
bfd_archive_filename (bfd *abfd)
{
if (abfd == NULL)
! return _("<unknown>");
if (abfd->my_archive)
{
--- 509,515 ----
bfd_archive_filename (bfd *abfd)
{
if (abfd == NULL)
! return NULL;
if (abfd->my_archive)
{