This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: gas:Reject ++ and --
- From: Andreas Schwab <schwab at suse dot de>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Nathan Sidwell <nathan at codesourcery dot com>,Alan Modra <amodra at bigpond dot net dot au>, binutils at sources dot redhat dot com,Michal Ostrowski <mostrows at watson dot ibm dot com>
- Date: Sat, 22 May 2004 14:37:24 +0200
- Subject: Re: gas:Reject ++ and --
- References: <40587B89.5050107@codesourcery.com><20040416015426.GA2557@bubble.modra.org><407FFBB1.4000804@codesourcery.com><20040518193527.GL5191@sunsite.ms.mff.cuni.cz>
Jakub Jelinek <jakub@redhat.com> writes:
> Even with this fix the ++/-- patch breaks previously working code.
> E.g. Linux kernel contains:
> #define MOVE_SHORTCHUNK(src, dst, offset, t0, t1) \
> ldub [%src - offset - 0x02], %t0; \
> ldub [%src - offset - 0x01], %t1; \
> stb %t0, [%dst - offset - 0x02]; \
> stb %t1, [%dst - offset - 0x01];
> ...
> MOVE_SHORTCHUNK(o1, o0, -0x02, g2, g3)
> MOVE_SHORTCHUNK(o1, o0, -0x04, g2, g3)
> MOVE_SHORTCHUNK(o1, o0, -0x06, g2, g3)
> MOVE_SHORTCHUNK(o1, o0, -0x08, g2, g3)
> MOVE_SHORTCHUNK(o1, o0, -0x0a, g2, g3)
> MOVE_SHORTCHUNK(o1, o0, -0x0c, g2, g3)
> MOVE_SHORTCHUNK(o1, o0, -0x0e, g2, g3)
> MOVE_SHORTCHUNK(o1, o0, -0x10, g2, g3)
How about putting parentheses around offset above?
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."