This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] MIPS: Incorrect calculation for R_MIPS_LO16 relocs


Richard Sandiford <rsandifo@redhat.com> writes:
> I'm uneasy about this approach.  In the ABI, R_MIPS_LO16 is defined
> entirely in terms of its own offset.  Nothing says that the LO16 offset
> is formed by adding in the high-part offset.

Oops!  I take that back.  Serves me right from going on memory. ;(

Still, it is an ABI change, as indicated by your follow-on patches.
We've traditionally been able to cope with R_MIPS_LO16 relocations
without finding their corresponding high part.  So...

> IMO this should be fixed some other way.

...I still think this is true.

Richard


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]