This is the mail archive of the
mailing list for the binutils project.
Re: [RFA] rda/samples: improve memory allocation
- From: mec dot gnu at mindspring dot com (Michael Elizabeth Chastain)
- To: binutils at sources dot redhat dot com, cagney at gnu dot org,gdb-patches at sources dot redhat dot com, msnyder at redhat dot com,rda at sources dot redhat dot com
- Date: Fri, 9 Jul 2004 23:26:23 -0400 (EDT)
- Subject: Re: [RFA] rda/samples: improve memory allocation
Michael Snyder writes:
+ #define ALLOC_UNIT 0x1000;
Oops, extra semicolon!
+ #define alloc_roundup(LEN) ((LEN / ALLOC_UNIT) + ALLOC_UNIT)
This looks like it's missing a multiplication again by ALLOC_UNIT.
Say, if LEN is 0x3000, then alloc_roundup(LEN) comes out to 0x1003
which seems weird.
#define alloc_roundup(LEN) ((((LEN)+ALLOC_UNIT-1) / ALLOC_UNIT) * ALLOC_UNIT)
Or I dunno exactly what you want, but that definition doesn't look
right. Looks like a missing call to alloc_coffee somewhere ...