Re: FAIL: i386 pcrel reloc [Was: Results for binutils 2.15.91 20040826testsuite on i686-pc-cygwin]

[Nick Clifton <nickc at redhat dot com>]

Hi H. J.  Hi Chris,

> > ../as-new  --32  -o dump.o /usr/local/src/trunk/src/gas/testsuite/gas/i386/pcrel.s
> > /usr/local/src/trunk/objdir-binutils/gas/testsuite/../../binutils/objdump  -drw dump.o > dump.out
> > regexp_diff match failure
> > regexp "^  ( 0:	e9 30 12 00 00[	 ]*jmp    1235 .*1: R_386_PC32	\*ABS\*| 0:	e9 2f 12 00 00[	 ]*jmp    1234 .*1: DISP32	\*ABS\*)$"
> > line   "   0:	e9 35 12 00 00       	jmp    123a <glob2+0x1135>	1: DISP32	*ABS*"
> > regexp_diff match failure

> The expect output is ELF. I have no idea why we bother to run it for
> non-ELF targets.

So how about this patch to make the test ELF specific, and also to tidy 
up the i386.exp file so that all the ELF tests are gathered together and 
to make it use the is_elf_format proc ?

Cheers
  Nick

gas/testsuite/ChangeLog
2004-08-26  Nick Clifton  <nickc@redhat.com>

	* gas/i386/i386.exp: Group ELF specific tests together.  Move
	the pcrel test into the ELF only section.  Use is_elf_format to
	test for ELF based toolchains.

Index: gas/testsuite/gas/i386/i386.exp
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/i386/i386.exp,v
retrieving revision 1.24
diff -c -3 -p -r1.24 i386.exp
*** gas/testsuite/gas/i386/i386.exp	21 Jul 2004 16:09:43 -0000	1.24
--- gas/testsuite/gas/i386/i386.exp	26 Aug 2004 16:05:37 -0000
*************** if [expr ([istarget "i*86-*-*"] ||  [ist
*** 54,91 ****
      run_dump_test "ssemmx2"
      run_dump_test "sse2"
      run_dump_test "absrel"
-     run_dump_test "pcrel"
      run_dump_test "sub"
      run_dump_test "prescott"
      run_dump_test "divide"
      run_dump_test "padlock"
  
-     # PIC is only supported on ELF targets.
-     if { ([istarget "*-*-elf*"] || [istarget "*-*-linux*"] )
- 	 && ![istarget *-*-linux*aout*]
- 	 && ![istarget *-*-linux*oldld*] } then {
- 	run_dump_test "intelpic"
-     }
- 
      # These tests require support for 8 and 16 bit relocs,
      # so we only run them for ELF and COFF targets.
!     if {[istarget "*-*-elf*"] || [istarget "*-*-linux*"] || [istarget "*-*-coff*"]} then {
  	run_dump_test "reloc"
  	run_dump_test "jump16"
  	run_list_test "white" "-al --listing-lhs-width=3"
      }
  
!     # Do they only work for ELF?
!     if { ([istarget "*-*-elf*"]		
! 	  || [istarget "*-*-linux*"]
! 	 && ![istarget *-*-linux*aout*]
! 	 && ![istarget *-*-linux*oldld*])
!     } then {
  	run_dump_test "relax"
  	run_dump_test "gotpc"
  	run_dump_test "tlsd"
  	run_dump_test "tlspic"
  	run_dump_test "tlsnopic"
      }
  
      # This is a PE specific test.
--- 54,83 ----
      run_dump_test "ssemmx2"
      run_dump_test "sse2"
      run_dump_test "absrel"
      run_dump_test "sub"
      run_dump_test "prescott"
      run_dump_test "divide"
      run_dump_test "padlock"
  
      # These tests require support for 8 and 16 bit relocs,
      # so we only run them for ELF and COFF targets.
!     if {[is_elf_format] || [istarget "*-*-coff*"]} then {
  	run_dump_test "reloc"
  	run_dump_test "jump16"
  	run_list_test "white" "-al --listing-lhs-width=3"
      }
  
!     # ELF specific tests
!     if [is_elf_format] then {
! 	# PIC is only supported on ELF targets.
! 	run_dump_test "intelpic"
! 
  	run_dump_test "relax"
  	run_dump_test "gotpc"
  	run_dump_test "tlsd"
  	run_dump_test "tlspic"
  	run_dump_test "tlsnopic"
+ 	run_dump_test "pcrel"
      }
  
      # This is a PE specific test.