This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] Fix strings to work with > 2GB files again on 32-bit arches
On Tue, Oct 12, 2004 at 08:45:06AM +0930, Alan Modra wrote:
> On Mon, Oct 11, 2004 at 10:20:28PM +0200, Jakub Jelinek wrote:
> > 2003-11-07 changes broke strings on arches with 32-bit off_t.
> > The following patch fixes this, although I'm not sure if the
>
> What about all the other uses of get_file_size? Shouldn't you be fixing
> get_file_size instead?
All the other tools work with object files and handling there
> 2GB files would require more changes than just get_file_size.
strings works on all files and is ATM the only one using fopen64/etc.
Plus I really think strings should work also on devices, which get_file_size
refuses and it should work also on zero length files, which get_file_size
doesn't like either.
Jakub