This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] Readelf patch to group common symbols.
- From: Nick Clifton <nickc at redhat dot com>
- To: Prafulla Thakare <PrafullaT at KPITCummins dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Thu, 16 Dec 2004 12:00:26 +0000
- Subject: Re: [PATCH] Readelf patch to group common symbols.
- References: <4A1BE23A7B777442B60F4B4916AE0F1303B6ACCB@sohm.kpit.com>
Hi Prafulla,
Please find attached the patch for readelf. This is developed to group
all the common symbols from different compilation unit if built in debug
> mode.
Thanks for submitting this patch. Unfortunately I have some issues with it:
* Why is this feature necessary ? Surely this information can be
gleaned from the switches already supported by readelf ?
* Does KPIT have an FSF assignment in place ? I could only find one:
KPIT InfoSystems Ltd. 2002-02-26
Assigns past and future changes. (tc-sh.c)
anandk@kpit.com (Anandkumar Keshavan)
* The new code in the patch does not follow the GNU Coding Standard.
* Since this patch adds a new feature to readelf there should be
patches to binutils/NEWS to announce it and binutils/doc/binutils.texi
to document it.
* A binutils testsuite entry to check the new functionality provided
by the patch would be very welcome.
I hope that you will consider these issues and get back to us with a
revised patch.
Cheers
Nick