This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] ia64: accept alternative forms of .pred.rel
- From: James E Wilson <wilson at specifixinc dot com>
- To: Jan Beulich <JBeulich at novell dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Mon, 31 Jan 2005 12:48:41 -0800
- Subject: Re: [PATCH] ia64: accept alternative forms of .pred.rel
- References: <s1fe5d93.014@emea1-mh.id2.novell.com>
On Mon, 2005-01-31 at 08:32, Jan Beulich wrote:
> Change to allow ias forms of .pred.rel (with @-prefixed designators).
Neither the Intel Assembly Language Reference Guide nor the Intel
Assembler User's Guide mentions this syntax. Where did it come from?
We already have two supported syntaxes. Do we really need a third one?
I do agree that using @ operators here makes sense though, as it makes
it more similar to how other directives work, but I'd like to know more
about why we need it.
Otherwise, this looks OK.
> Also
> eliminate a memory leak in the original code dealing with the quoted
> form.
There are 3 places that call demand_copy_C_string, and only one calls
obstack_free afterwards. The other one is much harder to fix though.
Curiously, I see that tc-ia64.c is not the only config file that calls
demand_copy_C_string, but it is the only one calling obstack_free
afterwards. It does look like the right thing to do though.
--
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com