This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] Re: .macro behavior
- From: "Jan Beulich" <JBeulich at novell dot com>
- To: <hp at bitrange dot com>
- Cc: <binutils at sources dot redhat dot com>
- Date: Tue, 08 Feb 2005 18:19:28 +0100
- Subject: Re: [PATCH] Re: .macro behavior
>> >> only allows [[:alpha:]_$][[:alnum:]_$]*
>
>I think this restriction is actually good. Calls for the least
>amount of surprises when applying the same macro to different
>GAS ports.
Not so. If, on IA-64 as an example, I want to define an
instruction-like macro, I need to have '.' as an acceptable character
for the macro name.
>> * gas/mmix/relax2.s: Use .altmacro and & to separate macro
>> parameter
>> references.
>
>Ew. Please just get rid of the ":"s instead (my mistake, as
>it's a symbol character, not the usual label-ending thingy).
I can't: The test just fails (with an error message that says nothing
to me) if I do so.
>And a nitpick:
>
>>
/home/jbeulich/src/binutils/mainline/2005-02-01/gas/testsuite/gas/mmix/relax2.s 2003-10-18
>> 18:00:21.000000000 +0200
>> +++ 2005-02-01/gas/testsuite/gas/mmix/relax2.s 2005-02-08
>> 09:38:12.000000000 +0100
>> @@ -1,35 +1,37 @@
>> # PUSHJ stub border-cases: two with either or both stubs
unreachable,
>> # local symbols, ditto non-local labels, similar with three
PUSHJs.
>>
>> +.altmacro
>> +
>
>Pseudos shouldn't be first on a line. Accepting it in gas is ok,
>but we shouldn't get sloppy in the test-suite. For consistency,
>it should also be aligned with the other pseudos in that file.
>(I guess you don't need the ".altmacro" pseudo if you just
>remove the ":"s so this is mostly for the record.)
Will do.
Thanks, Jan