This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] MIPS/ELF: Fixes for external R_MIPS16_GPREL relocations
- From: Thiemo Seufer <ica2_ts at csv dot ica dot uni-stuttgart dot de>
- To: "Maciej W. Rozycki" <macro at mips dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Wed, 9 Feb 2005 01:05:59 +0100
- Subject: Re: [PATCH] MIPS/ELF: Fixes for external R_MIPS16_GPREL relocations
- References: <Pine.LNX.4.61.0502031621340.13441@perivale.mips.com>
Maciej W. Rozycki wrote:
> Hello,
>
> While peeking at code to handle GPREL relocations I've discovered another
> discrepancy, with R_MIPS16_GPREL ones this time. Unlike the others, the
> (n)64 code treats such relocations against external symbols as if they
> were against local ones.
>
> Here is a fix -- tested for the mips64-linux-gnu, mipsel-linux-gnu and
> mips64el-elf targets with no regressions.
>
> 2005-02-03 Maciej W. Rozycki <macro@mips.com>
>
> * elf64-mips.c (mips16_gprel_reloc): Update a comment.
> * elfn32-mips.c (mips16_gprel_reloc): Keep R_MIPS16_GPREL
> relocations against external symbols unchanged.
>
> OK to apply?
Ok.
Thiemo