This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] ia64: certain symbol names were unusable


On Tue, 2005-02-08 at 03:16, Jan Beulich wrote:
> +      if (name[1] == 'n' && ISDIGIT (name[idx = 2]))
> +	dr = &md.in;

Please don't hide assignments like this.  It makes the code hard to
read.  This should be name[2] with "idx = 2;" on a separate line.

> +      if (name[1] == 'o' && name[2] == 'c' && ISDIGIT (name[idx =
> 3]))
> +	dr = &md.loc;

Likewise.

> +      if (name[1] == 'u' && name[2] == 't' && ISDIGIT (name[idx =
> 3]))
> +	dr = &md.out;

Likewise.

> +  if (dr && (name[idx] != '0' || name[idx + 1] == '\0'))

This one puzzled me for a while.  There should be a comment explaining
what it is for, to ignore any number with a leading zero, other than
zero itself.

Otherwise this is OK.
-- 
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]