This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

PATCH: Disable hint in B unit for Montecito


Montecito supports the hint@pause on .i, .m, .f ports only. hint@pause
on a b syllable decodes to a nop. Anticipated performance gains may not
be realized for any hint@pause.b instruction.

BTW, Montecito is the code name for the next Itanium processor. The 2.4
and 2.6 Linux kernels are OK with this patch.



H.J.
---
gas/

2005-02-16  H.J. Lu  <hongjiu.lu@intel.com>

	* NEWS: Mention "-mhint.b=[ok|warning|error]".

	* config/tc-ia64.c (md): Add hint_b.
	(emit_one_bundle): Don't emit "hint" in B unit if md.hint_b
	isn't ok.
	(md_parse_option): Accepted "-mhint.b=[ok|warning|error]".
	(md_show_usage): Add "-mhint.b=[ok|warning|error]".
	(ia64_init): Set md.hint_b to error.
	(md_assemble): Handle md.hint_b for "hint.b".

	* doc/as.texinfo: Add "-mhint.b=[ok|warning|error]".
	* doc/c-ia64.texi: Likewise.

gas/testsuite/

2005-02-16  H.J. Lu  <hongjiu.lu@intel.com>

	* gas/ia64/hint.b-err.l: New file.
	* gas/ia64/hint.b-err.s: Likewise.
	* gas/ia64/hint.b-warn.l: Likewise.
	* gas/ia64/hint.b-warn.s: Likewise.

	* gas/ia64/ia64.exp: Run hint.b-err and hint.b-warn.

	* gas/ia64/opc-b.d: Pass -mhint.b=ok to as.

--- gas/NEWS.hint	2005-02-14 09:31:16.901853962 -0800
+++ gas/NEWS	2005-02-14 09:38:16.167586419 -0800
@@ -1,5 +1,7 @@
 -*- text -*-
 
+* New command line option -mhint.b=[ok|warning|error] for IA64 targets.
+
 * New command line option -munwind-check=[warning|error] for IA64
   targets.
 
--- gas/config/tc-ia64.c.hint	2005-02-14 09:31:17.057833772 -0800
+++ gas/config/tc-ia64.c	2005-02-14 09:37:19.873872780 -0800
@@ -221,6 +221,14 @@ static struct
        that are predicatable.  */
     expressionS qp;
 
+    /* What to do when hint.b is used.  */
+    enum
+      {
+	hint_b_error,
+	hint_b_warning,
+	hint_b_ok
+      } hint_b;
+
     unsigned int
       manual_bundling : 1,
       debug_dv: 1,
@@ -6564,9 +6572,16 @@ emit_one_bundle ()
 	  enum ia64_opnd opnd1, opnd2;
 
 	  if ((strcmp (idesc->name, "nop") == 0)
-	      || (strcmp (idesc->name, "hint") == 0)
 	      || (strcmp (idesc->name, "break") == 0))
 	    insn_unit = required_unit;
+	  else if (strcmp (idesc->name, "hint") == 0)
+	    {
+	      if (required_unit == IA64_UNIT_B
+		  && md.hint_b != hint_b_ok)
+		insn_unit = IA64_UNIT_I;
+	      else
+		insn_unit = required_unit;
+	    }
 	  else if (strcmp (idesc->name, "chk.s") == 0
 	      || strcmp (idesc->name, "mov") == 0)
 	    {
@@ -6775,6 +6790,18 @@ md_parse_option (c, arg)
 	  else
 	    return 0;
 	}
+      else if (strncmp (arg, "hint.b=", 7) == 0)
+	{
+	  arg += 7;
+	  if (strcmp (arg, "ok") == 0)
+	    md.hint_b = hint_b_ok;
+	  else if (strcmp (arg, "warning") == 0)
+	    md.hint_b = hint_b_warning;
+	  else if (strcmp (arg, "error") == 0)
+	    md.hint_b = hint_b_error;
+	  else
+	    return 0;
+	}
       else
 	return 0;
       break;
@@ -6889,6 +6916,8 @@ IA-64 options:\n\
   -mle | -mbe		  select little- or big-endian byte order (default -mle)\n\
   -munwind-check=[warning|error]\n\
 			  unwind directive check (default -munwind-check=warning)\n\
+  -mhint.b=[ok|warning|error]\n\
+			  hint.b check (default -mhint.b=error)\n\
   -x | -xexplicit	  turn on dependency violation checking\n\
   -xauto		  automagically remove dependency violations (default)\n\
   -xnone		  turn off dependency violation checking\n\
@@ -7241,6 +7270,7 @@ ia64_init (argc, argv)
   md.detect_dv = 1;
   /* FIXME: We should change it to unwind_check_error someday.  */
   md.unwind_check = unwind_check_warning;
+  md.hint_b = hint_b_error;
 }
 
 /* Return a string for the target object file format.  */
@@ -10432,6 +10462,20 @@ md_assemble (str)
 		    TOUPPER (unit));
 	}
     }
+  else if (strcmp (idesc->name, "hint.b") == 0)
+    {
+      switch (md.hint_b)
+	{
+	case hint_b_ok:
+	  break;
+	case hint_b_warning:
+	  as_warn ("hint.b may be treated as nop");
+	  break;
+	case hint_b_error:
+	  as_bad ("hint.b shouldn't be used");
+	  break;
+	}
+    }
 
   qp_regno = 0;
   if (md.qp.X_op == O_register)
--- gas/doc/as.texinfo.hint	2005-02-11 13:18:37.000000000 -0800
+++ gas/doc/as.texinfo	2005-02-14 09:33:54.644436595 -0800
@@ -316,6 +316,7 @@ gcc(1), ld(1), and the Info entries for 
    [@b{-milp32}|@b{-milp64}|@b{-mlp64}|@b{-mp64}]
    [@b{-mle}|@b{mbe}]
    [@b{-munwind-check=warning}|@b{-munwind-check=error}]
+   [@b{-mhint.b=ok}|@b{-mhint.b=warning}|@b{-mhint.b=error}]
    [@b{-x}|@b{-xexplicit}] [@b{-xauto}] [@b{-xdebug}]
 @end ifset
 @ifset IP2K
--- gas/doc/c-ia64.texi.hint	2005-02-14 09:31:17.324799218 -0800
+++ gas/doc/c-ia64.texi	2005-02-14 09:33:54.645436465 -0800
@@ -73,6 +73,15 @@ will make the assembler issue a warning 
 fails.  This is the default.  @code{-munwind-check=error} will make the
 assembler issue an error when an unwind directive check fails.
 
+@item -mhint.b=ok
+@item -mhint.b=warning
+@item -mhint.b=error
+These options control what assembler will do when the @samp{hint.b}
+instruction is used. @code{-mhint.b=ok} will make assembler to accept
+@samp{hint.b}.  @code{-mhint.b=warning} will make assembler to issue
+a warning when @samp{hint.b} is used.  @code{-mhint.b=error} will make
+assembler to treat @samp{hint.b} as an error, which is the default.
+
 @item -x
 @item -xexplicit
 These options turn on dependency violation checking.
--- gas/testsuite/gas/ia64/hint.b-err.l.hint	2005-02-14 09:33:54.645436465 -0800
+++ gas/testsuite/gas/ia64/hint.b-err.l	2005-02-14 09:33:54.645436465 -0800
@@ -0,0 +1,3 @@
+.*: Assembler messages:
+.*:1: Error: hint.b shouldn't be used
+.*:2: Error: hint.b shouldn't be used
--- gas/testsuite/gas/ia64/hint.b-err.s.hint	2005-02-14 09:33:54.646436336 -0800
+++ gas/testsuite/gas/ia64/hint.b-err.s	2005-02-14 09:33:54.646436336 -0800
@@ -0,0 +1,2 @@
+	hint.b	@pause
+	hint.b	0x1ffff
--- gas/testsuite/gas/ia64/hint.b-warn.l.hint	2005-02-14 09:33:54.646436336 -0800
+++ gas/testsuite/gas/ia64/hint.b-warn.l	2005-02-14 09:33:54.646436336 -0800
@@ -0,0 +1,3 @@
+.*: Assembler messages:
+.*:1: Warning: hint.b may be treated as nop
+.*:2: Warning: hint.b may be treated as nop
--- gas/testsuite/gas/ia64/hint.b-warn.s.hint	2005-02-14 09:33:54.647436206 -0800
+++ gas/testsuite/gas/ia64/hint.b-warn.s	2005-02-14 09:33:54.647436206 -0800
@@ -0,0 +1,2 @@
+	hint.b	@pause
+	hint.b	0x1ffff
--- gas/testsuite/gas/ia64/ia64.exp.hint	2005-02-14 09:31:17.834733215 -0800
+++ gas/testsuite/gas/ia64/ia64.exp	2005-02-14 09:33:54.647436206 -0800
@@ -72,4 +72,6 @@ if [istarget "ia64-*"] then {
     run_list_test "slot2" ""
     run_list_test "unwind-err" "-munwind-check=error"
     run_dump_test "operand-or"
+    run_list_test "hint.b-err" ""
+    run_list_test "hint.b-warn" "-mhint.b=warning"
 }
--- gas/testsuite/gas/ia64/opc-b.d.hint	2005-02-14 09:31:17.867728944 -0800
+++ gas/testsuite/gas/ia64/opc-b.d	2005-02-14 09:39:23.858824822 -0800
@@ -1,4 +1,4 @@
-#as: -xnone
+#as: -xnone -mhint.b=ok
 #objdump: -d
 #name: ia64 opc-b
 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]