This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: PATCH: Fix "FAIL: objcopy (simple copy)" for tic54x-coff
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: "H. J. Lu" <hjl at lucon dot org>
- Cc: binutils at sources dot redhat dot com
- Date: Tue, 22 Feb 2005 11:27:16 +1030
- Subject: Re: PATCH: Fix "FAIL: objcopy (simple copy)" for tic54x-coff
- References: <20050221210909.GA14151@lucon.org>
> * coffcode.h (coff_write_relocs): Clear the r_reserved field
> if COFF_REL_HAS_R_RESERVED is defined before swapping out
> relocation.
This should really be done by defining a coff_SWAP_reloc_out function
for these targets. I'm not disapproving of the patch since the coff
support is already a mess of macros, but I'm not willing to approve
the patch myself..
--
Alan Modra
IBM OzLabs - Linux Technology Centre