This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATCH: PR 757: Linker fails to set correct alignment for commonsymbol

From: Nick Clifton <nickc at redhat dot com>
To: "H. J. Lu" <hjl at lucon dot org>
Cc: binutils at sources dot redhat dot com
Date: Mon, 28 Feb 2005 15:45:37 +0000
Subject: Re: PATCH: PR 757: Linker fails to set correct alignment for commonsymbol
References: <20050222231845.GA13364@lucon.org>

Hi H. J.

2005-02-22 H.J. Lu <hongjiu.lu@intel.com>

	PR 757
	* elf-bfd.h (_bfd_elf_merge_symbol): Add a pointer to unsigned
	int.

	* elf32-sh-symbian.c (sh_symbian_relocate_section): Pass NULL
	to _bfd_elf_merge_symbol.

	* elflink.c (_bfd_elf_merge_symbol): Use the pointer to
	unsigned int to return the alignment of the old common symbol
	in the dynamic object.
	(_bfd_elf_add_default_symbol): Pass NULL to
	_bfd_elf_merge_symbol.
	(elf_link_add_object_symbols): Pass &old_alignment to
	_bfd_elf_merge_symbol. Get the alignment of the new common
	symbol in the dynamic object.

Have you tested this patch ? If so, and if it has not introduced any regressions, then please consider it approved.

Cheers
  Nick

References:
- PATCH: PR 757: Linker fails to set correct alignment for common symbol
  - From: H. J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]