This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] VAX: produce valid assembler when disassembling functionmask

From: Nick Clifton <nickc at redhat dot com>
To: Jan-Benedict Glaw <jbglaw at microdata-pos dot de>
Cc: binutils at sources dot redhat dot com
Date: Mon, 14 Mar 2005 09:47:59 +0000
Subject: Re: [PATCH] VAX: produce valid assembler when disassembling functionmask
References: <20050311233046.A24051@microdata-pos.de>

Hi Jan-Benedict,

When I introduced decoding of VAXens function entry mask some days
ago, I missed to let the output look like assembler. Using .word
and a comment was suggested by Kenn Humborg and I think it's a good
idea.

2005-03-11 Jan-Benedict Glaw <jbglaw@lug-owl.de>

	* vax-dis.c: Fix spelling error
	(print_insn_vax): Use ".word 0x0012 # Entry mask: r1 r2 >" instead
	of just "Entry mask: < r1 ... >"

Approved and applied. Although to be fair I think that you ought to have credited Kenn Humborg in the ChangeLog entry as well.

Cheers
  Nick

Follow-Ups:
- Re: [PATCH] VAX: produce valid assembler when disassembling function mask
  - From: Jan-Benedict Glaw

References:
- [PATCH] VAX: produce valid assembler when disassembling function mask
  - From: Jan-Benedict Glaw

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]