This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Binutils builds broken with -Werror

From: Nick Clifton <nickc at redhat dot com>
To: Andreas Schwab <schwab at suse dot de>
Cc: Dave Korn <dave dot korn at artimi dot com>, "'Ian Lance Taylor'" <ian at airs dot com>, "'Richard Sandiford'" <rsandifo at redhat dot com>, "'Daniel Jacobowitz'" <drow at false dot org>, binutils at sourceware dot org
Date: Wed, 23 Mar 2005 09:41:01 +0000
Subject: Re: Binutils builds broken with -Werror
References: <SERRANOuDzTo0xEsHut0000009b@SERRANO.CAM.ARTIMI.COM> <424065D9.4050005@redhat.com> <jeu0n3b90x.fsf@sykes.suse.de>

Hi Andreas,

NO_WERROR_COMPILE = $(COMPILE:Werror=Wno-error) do the desired trick?
Yes it will. But is this construct also GNU Make specific ?

It's POSIX.

Cool - in which case I guess we have to choose between this fix and a patch to the configure files. I prefer patching Makefile.am since I have always had difficulty getting configure files to work.

Any objections to this patch then ?

+ # Disable -Werror, if it has been enabled, when building generated C source + # files since old versions of bison & yacc will produce working code which + # contain compile time warnings. + GENERATED_OFILES := $(GENERATED_CFILES:.c=.o) + NO_WERROR_COMPILE = $(COMPILE:Werror=Wno-error) + $(GENERATED_OFILES): + $(NO_WERROR_COMPILE) -c `basename $@ .o`.c

Cheers
  Nick

References:
- RE: Binutils builds broken with -Werror
  - From: Dave Korn
- Re: Binutils builds broken with -Werror
  - From: Nick Clifton
- Re: Binutils builds broken with -Werror
  - From: Andreas Schwab

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]