This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Fix compilation warnings in irix-core.c

> > Spaces around the + please.
> 
> Daniel and Thiemo suggested changing the + into a |. I will make that
> change and test that, if you agree.
> 

I do. Don't forget the spacing :)

> >  irix_core_core_file_matches_executable_p (core_bfd, exec_bfd)
> > -     bfd *core_bfd, *exec_bfd;
> > +     bfd *core_bfd ATTRIBUTE_UNUSED, *exec_bfd ATTRIBUTE_UNUSED;
> > 
> > Can you move this to:
> > 
> > bfd *core_bfd ATTRIBUTE_UNUSED;
> > bfd *exec_bfd ATTRIBUTE_UNUSED;
> > 
> > please?
> 
> Sure.
> 
> > OK with those changes. Though if you want to migrate the whole file to
> > ISO I'd appreciate it. For style just look at, say, elfxx-mips.c :)
> 
> Sure. I'll try to do that today.
> 

Excellent.

-eric
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]