This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: Build error at FreeBSD in gas/symbols.c
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: "Vladimir A. Merzliakov" <wanderer at rsu dot ru>
- Cc: binutils at sourceware dot org
- Date: Mon, 11 Apr 2005 09:30:06 +0930
- Subject: Re: Build error at FreeBSD in gas/symbols.c
- References: <003901c53dd2$c8e05a20$10fcd0c3@npt>
On Sun, Apr 10, 2005 at 05:39:50PM +0400, Vladimir A. Merzliakov wrote:
> /usr/home/wanderer/pkg/build/binutils/src/src/gas/symbols.c:2035: warning:
> pointer targets in return differ in signedness
Thanks. I picked the wrong type for the function return, and missed a
needed cast.
* symbols.c (symbol_X_add_number): Warning fixes.
* symbols.h (symbol_X_add_number): Update prototype.
Index: gas/symbols.c
===================================================================
RCS file: /cvs/src/src/gas/symbols.c,v
retrieving revision 1.57
diff -u -p -r1.57 symbols.c
--- gas/symbols.c 9 Apr 2005 03:48:09 -0000 1.57
+++ gas/symbols.c 10 Apr 2005 23:38:16 -0000
@@ -2024,12 +2024,12 @@ symbol_set_value_expression (symbolS *s,
/* Return a pointer to the X_add_number component of a symbol. */
-valueT *
+offsetT *
symbol_X_add_number (symbolS *s)
{
#ifdef BFD_ASSEMBLER
if (LOCAL_SYMBOL_CHECK (s))
- return &((struct local_symbol *) s)->lsy_value;
+ return (offsetT *) &((struct local_symbol *) s)->lsy_value;
#endif
return &s->sy_value.X_add_number;
Index: gas/symbols.h
===================================================================
RCS file: /cvs/src/src/gas/symbols.h,v
retrieving revision 1.17
diff -u -p -r1.17 symbols.h
--- gas/symbols.h 9 Apr 2005 03:48:09 -0000 1.17
+++ gas/symbols.h 10 Apr 2005 23:38:16 -0000
@@ -175,7 +175,7 @@ extern symbolS *symbol_next (symbolS *);
extern expressionS *symbol_get_value_expression (symbolS *);
extern void symbol_set_value_expression (symbolS *, const expressionS *);
-extern valueT *symbol_X_add_number (symbolS *);
+extern offsetT *symbol_X_add_number (symbolS *);
extern void symbol_set_value_now (symbolS *);
extern void symbol_set_frag (symbolS *, fragS *);
extern fragS *symbol_get_frag (symbolS *);
--
Alan Modra
IBM OzLabs - Linux Technology Centre