This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: PATCH: Fix ia64 linker crash when reporting non-pic code error
On Wed, 2005-04-27 at 09:22, H. J. Lu wrote:
> * elf-bfd.h (bfd_elf_sym_name): Also take "asection *".
> * elf.c (bfd_elf_sym_name): Updated.
> (group_signature): Likewise.
> * elf32-ppc.c (ppc_elf_relocate_section): Likewise.
> * elf64-ppc.c (ppc64_elf_edit_opd): Likewise.
> (ppc64_elf_edit_toc): Likewise.
> (ppc64_elf_relocate_section): Likewise.
> * elfcode.h (elf_slurp_symbol_table): Likewise.
> * elflink.c (elf_link_input_bfd): Likewise.
> * elfxx-ia64.c (elfNN_ia64_relocate_section): Call
> bfd_elf_sym_name to get local symbol name when reporting errors.
Yes, I think this looks good, except that the elfxx-ia64.c patch has
only 4 hunks, and it should have 5. You missed one, which is the
bfd_reloc_notsupported case. OK with that fixed also.
--
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com